Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deep-queries): properly return insert result #803

Merged
merged 5 commits into from
Sep 10, 2024
Merged

fix(deep-queries): properly return insert result #803

merged 5 commits into from
Sep 10, 2024
+3 −2

Conversation

David-Kunz
Copy link
Contributor

@David-Kunz David-Kunz commented Sep 10, 2024 •
edited
Loading

For INSERTs, beforeData is always [] and

return beforeData.length ?? rootResult

would always return 0.

patricebender
patricebender reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@patricebender patricebender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test for this scenario?

@David-Kunz
Copy link
Contributor Author

@patricebender , done!

@David-Kunz David-Kunz enabled auto-merge (squash) September 10, 2024 11:48
@David-Kunz David-Kunz merged commit 8d800e2 into main Sep 10, 2024
4 checks passed
@David-Kunz David-Kunz deleted the insert_result branch September 10, 2024 11:56
@cap-bots cap-bots mentioned this pull request Sep 10, 2024
Merged
@David-Kunz David-Kunz mentioned this pull request Sep 30, 2024
Closed
johannes-vogel pushed a commit that referenced this pull request Oct 1, 2024
@cap-bots
chore: release main (#798)
5a2c1f0 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.13.0</summary>

##
[1.13.0](db-service-v1.12.1...db-service-v1.13.0)
(2024-10-01)


### Added

* Add quoted mode support
([#681](#681))
([43c7a6c](43c7a6c))


### Fixed

* **deep-queries:** properly return insert result
([#803](#803))
([8d800e2](8d800e2))
* dont use virtual key for `UPDATE … where (&lt;key&gt;) in <subquery>`
([#800](#800))
([d25af70](d25af70))
* reject all path expressions w/o foreign keys
([#806](#806))
([cd271a8](cd271a8))
</details>

<details><summary>hana: 1.3.0</summary>

##
[1.3.0](hana-v1.2.0...hana-v1.3.0)
(2024-10-01)


### Added

* Add quoted mode support
([#681](#681))
([43c7a6c](43c7a6c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobdenOs BobdenOs BobdenOs approved these changes

@oklemenz2 oklemenz2 oklemenz2 approved these changes

@patricebender patricebender patricebender approved these changes

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@sjvans sjvans Awaiting requested review from sjvans sjvans is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@David-Kunz @patricebender @oklemenz2 @BobdenOs